This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker. r=Rik, r=julienw, r=francisco, r=yurenju #22386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '(default)' + | ||
| '</span>' + | ||
| '</button>' + | ||
| '<button data-l10n-id="cancel">Cancel</button>' + |
There was a problem hiding this comment.
Gaia-menu should already ship with a cancel button by default. Is this needed?
DouglasSherk
force-pushed
the
1045820-sim-picker-dialer
branch
2 times, most recently
from
4b17799
to
7a9262c
Compare
… GaiaSimPicker. r=Rik, r=julienw, r=francisco, r=yurenju
DouglasSherk
force-pushed
the
1045820-sim-picker-dialer
branch
from
7a9262c
to
ebca893
Compare
|
|
Douglas Sherk (DouglasSherk)
| LazyLoader.load(['/shared/js/sim_picker.js'], function() { | ||
| SimPicker.getOrPick(cardIndex, phoneNumber, | ||
| self.performAction.bind(self)); | ||
| LazyLoader.load(['/shared/elements/gaia_sim_picker/script.js'], function() { |
There was a problem hiding this comment.
I'm quite new in web component,s but isn't it supposed to be loaded by the web components subsystem?
|
This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.